Webfrontend #386: Complete release views - collecting_society - C3S Tracker

Webfrontend #386

Complete release views

Added by Alexander Blum over 7 years ago. Updated almost 5 years ago.

Status:

Erledigt

Start date:

05/06/2018

Priority:

Dringend

Due date:

Assignee:

Thomas Mielke

% Done:

100%

Category:

Estimated time:

4.00 h

Target version:

Repertoire 1) Testing phase I

Spent time:

1.00 h

Description

list
add
show
edit
delete

Associated revisions

Revision 4a0745cb
Added by Thomas Mielke about 6 years ago

finished release (add, edit, list, show); solves #386

Revision 242ab0f7
Added by Alexander Blum almost 6 years ago

ref #386: adds release in context; fixes img classes

Revision 2fa28073
Added by Alexander Blum almost 6 years ago

ref #386: fixes edit release title

Revision d52562a2
Added by Alexander Blum almost 6 years ago

ref #386: merges tabs

Revision dcd1ac81
Added by Alexander Blum almost 6 years ago

ref #386: tidies up

Revision 30c666cc
Added by Alexander Blum over 5 years ago

ref #386, #388, #387: adds oid column for datatable sequences

Revision 130a7178
Added by Alexander Blum over 5 years ago

ref #386: adds release type and artist(s) gui

Revision 0859d04f
Added by Alexander Blum over 5 years ago

ref #386: adds track sequence

Revision 0c4ca025
Added by Alexander Blum over 5 years ago

ref #386: adds form logic for tracks; changes artist to single form

Revision 7085ff53
Added by Alexander Blum over 5 years ago

fixes #386: completes release views

History

#1 Updated by Alexander Blum over 7 years ago

Description updated (diff)

#2 Updated by Thomas Mielke about 7 years ago

Priority changed from Normal to Dringend

#3 Updated by Thomas Mielke over 6 years ago

Blocks Webfrontend #294: Check all views for internal IDs added

#4 Updated by Thomas Mielke over 6 years ago

Assignee set to Alexander Blum

\o/

#5 Updated by Thomas Mielke about 6 years ago

Status changed from Neu to In Bearbeitung
Assignee changed from Alexander Blum to Thomas Mielke
Start date set to 05/06/2018

Thomas officially grabbed this ticket now.

This is how I'd like to structure the tabs on the add/edit page:

GENERAL

title
number_mediums
ean_upc_code  
isrc_code 
picture_data 
picture_data_mime_type
warning

PRODUCTION

copyright_date
copyright_owner
production_date
producer

DISTRIBUTION

label 
label_catalog_number
release_date 
release_cancellation_date
online_release_date
online_cancellation_date 
distribution_territory

TRACKS

creations

GENRES

genres

RIGHTS SOCIETIES

neighbouring_rights_society

Changed label_order_number to label_catalog_number.

Open question: Don't we need a media type field, e.g. to know if it is the CD or the vinyl release?

#6 Updated by Thomas Mielke about 6 years ago

Status changed from In Bearbeitung to Feedback
Assignee changed from Thomas Mielke to Alexander Blum

Need clarification why we have this OR condition: https://github.com/C3S/collecting_society.portal.repertoire/commit/b1a3c6775c69c879bdc22fb651b416a18c760119#diff-c7361c7a1e931e1ebcf97d50f4b8d541L49

Maybe replace with entity_creator like this?:

     return cls.get().search([
        [
            'OR',
            ('entity_creator', '=', party_id),
            ('creations.creation.artist.party', '=', party_id)
        ],

#7 Updated by Thomas Mielke about 6 years ago

Why is Releases.ean_upc_code an int? int holds max 9 digits, ean codes need 13, upc codes need 12 digits.

#8 Updated by Thomas Mielke about 6 years ago

Don't we need an entry form to allow the user to enter mere party.addresses?

#9 Updated by Alexander Blum about 6 years ago

Thomas Mielke wrote:

This is how I'd like to structure the tabs on the add/edit page:

We need to check, how this number of tabs is displayed on smaller devices.

Open question: Don't we need a media type field, e.g. to know if it is the CD or the vinyl release?

Sounds reasonable. There was once a whole object for online release, if i remember correcly. This would also be one type to add.

#10 Updated by Alexander Blum about 6 years ago

Thomas Mielke wrote:

Why is Releases.ean_upc_code an int? int holds max 9 digits, ean codes need 13, upc codes need 12 digits.

Probably just a thoughtless error.

#11 Updated by Alexander Blum about 6 years ago

Thomas Mielke wrote:

Don't we need an entry form to allow the user to enter mere party.addresses?

For what reason?

#12 Updated by Alexander Blum about 6 years ago

Thomas Mielke wrote:

Need clarification why we have this OR condition: https://github.com/C3S/collecting_society.portal.repertoire/commit/b1a3c6775c69c879bdc22fb651b416a18c760119#diff-c7361c7a1e931e1ebcf97d50f4b8d541L49

This is just a relic. It was a short fix to associate releases with the webuser before we got EntityOrigin.